Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require make for JRuby 9 #4179

Merged
merged 3 commits into from Sep 19, 2017
Merged

Require make for JRuby 9 #4179

merged 3 commits into from Sep 19, 2017

Conversation

pkuczynski
Copy link
Member

Fixes #4058

@pkuczynski pkuczynski added this to the rvm-1.29.4 milestone Sep 19, 2017
mpapis
mpapis approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@mpapis mpapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fixes needed, otherwise it's good

scripts/functions/requirements/openmandriva Outdated
@@ -43,19 +43,24 @@ requirements_openmandriva_define()
(rvm)
requirements_check bash curl patch
;;

(jruby*)
true # not that easy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements_check make?

scripts/functions/requirements/unknown Outdated
(jruby*)
requirements_unknown_binaries make jave
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jave -> java?

@pkuczynski
Copy link
Member Author

Fixes applied...

@pkuczynski pkuczynski merged commit 7178d7a into master Sep 19, 2017
@pkuczynski pkuczynski deleted the bugfix/jruby-require-make branch September 19, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpapis mpapis mpapis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rvm-1.29.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkuczynski @mpapis