Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified wrapper command #4184

Merged
merged 1 commit into from Sep 23, 2017
Merged

Simplified wrapper command #4184

merged 1 commit into from Sep 23, 2017

Conversation

mpapis
Copy link
Member

@mpapis mpapis commented Sep 22, 2017

Simplified wrapper command

Closes #4180
Depends on rvm/gem-wrappers#12

@mpapis mpapis added the feature label Sep 22, 2017
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think, although I do not know enough to judge this PR in details.

The build fails though, so not sure if its ready to merge?

@mpapis mpapis force-pushed the feature/4180-simplified_wrapper branch 2 times, most recently from c999d48 to 5b13cb1 Compare September 23, 2017 01:17
mpapis added a commit to rvm/rvm-test that referenced this pull request Sep 23, 2017
mpapis added a commit to rvm/rvm-test that referenced this pull request Sep 23, 2017
@mpapis mpapis force-pushed the feature/4180-simplified_wrapper branch from 5b13cb1 to 100942a Compare September 23, 2017 02:19
@mpapis mpapis merged commit 2a1e2ff into master Sep 23, 2017
@mpapis mpapis deleted the feature/4180-simplified_wrapper branch September 23, 2017 02:57
@sekrett
Copy link
Contributor

sekrett commented Nov 16, 2017

@mpapis is it a spelling error in 'regenrate'?

@mpapis
Copy link
Member Author

mpapis commented Nov 17, 2017

@sekrett yes, could you open a PR?

@sekrett sekrett mentioned this pull request Nov 18, 2017
@pkuczynski pkuczynski added this to the rvm-1.29.4 milestone Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper fails to find testrb file
3 participants