Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version selected for TruffleRuby binary install #4662

Merged
merged 4 commits into from
Apr 15, 2019

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Apr 11, 2019

Fixes #4633.

cc @pkuczynski

Relates to #4456 and #4297.

@eregon
Copy link
Contributor Author

eregon commented Apr 11, 2019

It's a quite surprising that __rvm_ruby_string_parse didn't run before __rvm_ruby_package_file is called.
JRuby has a similar trick above to workaround this problem:

      __version="$(
        rvm_ruby_string="$1"
        rvm_remote_flag=0 __rvm_ruby_string
        echo "$rvm_ruby_version"
      )"

eregon added a commit to eregon/rvm-test that referenced this pull request Apr 11, 2019
@eregon
Copy link
Contributor Author

eregon commented Apr 11, 2019

Test in rvm/rvm-test#27

@pkuczynski pkuczynski added this to the rvm-1.29.8 milestone Apr 15, 2019
@pkuczynski pkuczynski added the bug label Apr 15, 2019
@pkuczynski pkuczynski merged commit 3a94781 into rvm:master Apr 15, 2019
pkuczynski pushed a commit to rvm/rvm-test that referenced this pull request Apr 15, 2019
eregon added a commit to eregon/rvm that referenced this pull request Apr 21, 2019
* To test rvm/rvm-test#27 in rvm's CI.
* See rvm#4662 for the fix.
@eregon eregon mentioned this pull request Apr 21, 2019
pkuczynski pushed a commit that referenced this pull request Apr 24, 2019
* To test rvm/rvm-test#27 in rvm's CI.
* See #4662 for the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truffleruby-1.0.0-rc13 resolves to truffleruby-1.0.0-rc11
2 participants