Filter redundant/incompatible rvm_gem_options #4705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any occurrence of
--no-document
,--no-ri
and--no-rdoc
fromrvm_gem_options
when merging with the auto-detectedinstall_params
to avoid duplicate, deprecated or incompatible options.This should fix the current test failures for ruby-1.8.7 under Xenial on Travis CI, where the default Travis
~/.rvmrc
containsrvm_gem_options='--no-ri --no-rdoc --no-document'
breaking rvm gem installs with rubygems 1.8.25 which does not yet support the--no-document
option.