Ignore aliases when using ls command

[skunkworker]

This is an addendum on #4282 for ZSH and possibly other shells.
The current version works fine on bash when alias ls='something-not-ls' but on zsh alias ls='something-not-ls' is called it currently fails.

It also fixes another ls command invocation in is_gem_installed().

Where /bin/ls is installed, this is used instead of the terminals ls short command. Otherwise it defaults to the shell sessions ls alias if it doesn't find it.

This can be helpful to make sure the default command doesn't have extra arguments.

This was my first attempt and I was able to get rid of the bug, but I think it might be worth it to move the _ls_command command out of the function.

[pkuczynski]

We write wrappers over system commands in scripts/functions/support. In this the best case would be to define it in __rvm_setup_utils_functions_common():

__rvm_ls() { \command \ls "$@" || return $?; }

This definition should ignore aliases. Then you should be able to use _rvm_ls in functions/gemset. Can you give it a try please?

[skunkworker]

We write wrappers over system commands in scripts/functions/support. In this the best case would be to define it in __rvm_setup_utils_functions_common():

__rvm_ls() { \command \ls "$@" || return $?; }

This definition should ignore aliases. Then you should be able to use _rvm_ls in functions/gemset. Can you give it a try please?

Thanks @pkuczynski this seemed to work on my ZSH environment just fine with the aliasing.

[pkuczynski]

Looks better! @mpapis what you think?

We are only missing CHANGELOG entry...