Run all JRuby commands from gemset down using --dev flag #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemset install time substantially (50.9s -> 40.5s locally). The rationale for this change is that short-running JRuby processes should use --dev because it disables a bunch of optimizations and essentially just runs using the startup interpreter. This hurts eventual performance but it also speeds up short-lived processes. I do not think I did this quite right but I put it in as a starting point. mpapis helped me find the proper place but I need guidance on proper code itself.
|
Doh! I did not see the CHANGELOG or other boiler plate. I will update once we hammer out what needs to change. |
…BY_OPTS to cascade settings
pkuczynski
previously approved these changes
Oct 28, 2019
pkuczynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run all JRuby commands from gemset down using --dev flag. This reduces gemset install
time substantially (50.9s -> 40.5s locally). The rationale
for this change is that short-running JRuby processes should use --dev because
it disables a bunch of optimizations and essentially just runs using the
startup interpreter. This hurts eventual performance but it also speeds up
short-lived processes.
I do not think I did this quite right but I put it in as a starting point.
mpapis helped me find the proper place but I need guidance on proper code
itself.