Do not warn if using a development version newer than the latest release #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, using latest RVM would show: Warning, new version of rvm available '1.29.9', you are using older version '1.29.9-next'. You can disable this warning with: echo rvm_autoupdate_flag=0 >> ~/.rvmrc You can enable auto-update with: echo rvm_autoupdate_flag=2 >> ~/.rvmrc You can update manually with: rvm get VERSION (e.g. 'rvm get stable')
pkuczynski
reviewed
Feb 17, 2020
| @@ -28,6 +28,7 @@ | |||
| * Fixes checksums for Ruby 2.6.4 [\#4769](https://github.com/rvm/rvm/pull/4769), 2.4.7 and 2.5.6 [\#4771](https://github.com/rvm/rvm/pull/4771) | |||
| * Update TruffleRuby dependencies [\#4815](https://github.com/rvm/rvm/pull/4815) | |||
| * Use ruby.git master instead of trunk [\#4840](https://github.com/rvm/rvm/pull/4840) | |||
| * Fix RVM version check when using a version newer than the latest release [#4872](https://github.com/rvm/rvm/pull/4872) | |||
There was a problem hiding this comment.
I was planning to do this fix ages ago and never found time! Thanks!
There was a problem hiding this comment.
😃 Could you merge the PR? Or should we wait for @mpapis' review?
There was a problem hiding this comment.
Spoke with @mpapis and he liked your PR, so I will merge it now :)
pkuczynski
approved these changes
Feb 17, 2020
| @@ -180,6 +180,9 @@ __rvm_cli_autoupdate_version_old() | |||
| online_version="$( __rvm_version_remote )" | |||
| version_release="$(\command \cat "$rvm_path/RELEASE" 2>/dev/null)" | |||
| : version_release:"${version_release:=master}" | |||
| if [[ "${online_version}-next" == "${rvm_version%% *}" ]]; then # development version newer than latest release | |||
There was a problem hiding this comment.
I think instead of this check, we should rather modify the online_version fetch above, to drop -next. @mpapis what you think?
There was a problem hiding this comment.
Or maybe rather the condition below?
| @@ -28,6 +28,7 @@ | |||
| * Fixes checksums for Ruby 2.6.4 [\#4769](https://github.com/rvm/rvm/pull/4769), 2.4.7 and 2.5.6 [\#4771](https://github.com/rvm/rvm/pull/4771) | |||
| * Update TruffleRuby dependencies [\#4815](https://github.com/rvm/rvm/pull/4815) | |||
| * Use ruby.git master instead of trunk [\#4840](https://github.com/rvm/rvm/pull/4840) | |||
| * Fix RVM version check when using a version newer than the latest release [#4872](https://github.com/rvm/rvm/pull/4872) | |||
There was a problem hiding this comment.
Spoke with @mpapis and he liked your PR, so I will merge it now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which seems clearly a bug.