Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for truffleruby 19.0.2, 19.1.1, 19.2.1, 19.3.0.2 #4910

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Conversation

pkuczynski
Copy link
Member

No description provided.

@pkuczynski pkuczynski added this to the rvm-1.29.11 milestone Apr 14, 2020
@pkuczynski pkuczynski requested a review from eregon April 14, 2020 14:09
@pkuczynski pkuczynski self-assigned this Apr 14, 2020
config/known Outdated
@@ -33,6 +33,7 @@ rbx-4[.12]
rbx-head

# TruffleRuby
truffleruby-19[.3.1]
Copy link
Contributor

@eregon eregon Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add this, anyone using TruffleRuby should use the latest release, and TruffleRuby 19.3.x is not maintained except for security fixes.

@eregon
Copy link
Contributor

eregon commented Apr 14, 2020

Looks good. Note that most of these releases are Critical Patch Updates releases, i.e., 19.x.y is the same as 19.x.0 + some security fixes.

In practice, TruffleRuby is still experimental and so using 19.x.y doesn't make much sense, 20.0+ has the security fixes and is far more compatible.
That's why I didn't bother to add those releases, but we can add them, that's fine too.
So currently, we consider only the latest release of TruffleRuby to be the one people should use, previous versions are simply less compatible and we don't maintain them beyond security fixes.

19.3.0.2 is 19.3.0 + some bug fixes which don't seem particularly relevant for TruffleRuby: https://www.graalvm.org/docs/release-notes/19_3/

See https://www.graalvm.org/docs/release-notes/version-roadmap/ for details.

@pkuczynski pkuczynski merged commit 0b67540 into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the truff branch April 14, 2020 22:11
@pkuczynski
Copy link
Member Author

I prefer to keep all hashes for security reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants