Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still maintained? #68

Closed
q2dg opened this issue Dec 10, 2016 · 22 comments
Closed

Is this project still maintained? #68

q2dg opened this issue Dec 10, 2016 · 22 comments

Comments

@q2dg
Copy link

q2dg commented Dec 10, 2016

Last closed issues and merged PR are from 2014...so I'd like to know the status of this tool.
Thanks

@aggsol
Copy link

aggsol commented Oct 6, 2017

I think we might need a fork

@eMPee584
Copy link

we might need a fork

uhhm.. there already seem to be about 20 🤣

@rvoicilas
Copy link
Collaborator

rvoicilas commented Jan 4, 2018

Uhm, it hasn't been maintained for the last 4 years or so - not sure if I'll have time starting from now on to do so, but I'm planning on giving it a try, at least to close some of the existing issues and PRs. Also, I just released 3.20.0 if this helps you.

@813gan
Copy link
Contributor

813gan commented Apr 21, 2018

@rvoicilas maybe You should give someone write access?

@jacobsvante
Copy link

@rvoicilas Any chance we might see 3.20.1 in OS package managers? Most seem to be stuck at 3.14

@cyc1ingsir
Copy link

@rvoicilas There have been a couple of commits since the last release 3.20.1.
Any chance, you could make a release 3.20.2 including these commits?
Including at least the PR #104 in the new release would be very welcome!

This would be really helpful to get a PR reviewed, providing a SynoCommunity package for this tools.
Thank you very much in advance

@ericcurtin
Copy link
Member

@rvoicilas we need someone to have write access or someone to start maintaining a fork, the former would be preferable so you could still be involved. Nothing has been merged in 2 years! I wanted to open a PR myself, but I wonder is it worth the effort if it's gonna stay in limbo.

@ericcurtin
Copy link
Member

@q2dg @aggsol @eMPee584 @rvoicilas @813gan @jmagnusson @cyc1ingsir @carlbordum @angerangel @bmwiedemann @itpflop @chipitsine @DabeDotCom @EdwardBetts @guilhermepiccoli @jackiehjm @yurivict @laindir @toconnor @ghost

I'm happy enough to maintain this as a fork if you'd like to open pull requests, issues, etc. here?

https://github.com/ericcurtin/inotify-tools

@813gan
Copy link
Contributor

813gan commented Jan 25, 2020

Hi @ericcurtin.
I very happy to see that someone cares about this pretty important project.
My PR needs some work but when i will clean up things i will open it for your fork.

Did you contact with package maintainers? I bet most of distros should switch to some fork as @rvoicilas seems to be dead...

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Jan 26, 2020

@ericcurtin Somehow I can open PRs to a hundred forks, but not yours. Feel free to git am my https://github.com/rvoicilas/inotify-tools/pull/97.patch

@carlbordum
Copy link
Contributor

@ericcurtin, thanks for doing this.

@bmwiedemann I experienced the same thing, some bug with GitHub. Try using the GUI starting from this link https://github.com/ericcurtin/inotify-tools/compare/master...carlbordum:master, then it worked for me.

@cyc1ingsir
Copy link

Nice move.
Maybe you could have a brief look over the PRs in this project.
#104 looks urgent to me.
A new release would be great too.

@rvoicilas
Copy link
Collaborator

@q2dg @aggsol @eMPee584 @rvoicilas @813gan @jmagnusson @cyc1ingsir @carlbordum @angerangel @bmwiedemann @itpflop @chipitsine @DabeDotCom @EdwardBetts @guilhermepiccoli @jackiehjm @yurivict @laindir @toconnor @ghost

I'm happy enough to maintain this as a fork if you'd like to open pull requests, issues, etc. here?

https://github.com/ericcurtin/inotify-tools

@ericcurtin Thank you for taking the time to get involved in this project. Unfortunately, my time has been limited over the last couple of years. I'm more than willing to help with the transition - I can add you as a collaborator to this project which presumably should you give you write access or I can point the current README to your fork of the project - whatever works best for you.

@ericcurtin
Copy link
Member

ericcurtin commented Jan 26, 2020

Thanks for the quick response @rvoicilas! Could you add me as a collaborator to this project? And I can look at all the pull requests issues here, rather than asking everyone to re-open everything.

And then you can get involved again if your time frees up again :)

It would save me rewriting all urls etc. I'd rather close the fork if possible.

@ericcurtin
Copy link
Member

Hi @rvoicilas I see I now have push access. Thanks for that! I can now merge some PRs :)

There are still many things I cannot do, such as edit the outdated url in the project description.

I created a https://github.com/orgs/inotify-tools organization so this project can have multiple owners with full access.

Could you accept that invite? Then I can set you as an owner and we can have multiple admins.

@rvoicilas
Copy link
Collaborator

@ericcurtin Done! Thank you!

@ericcurtin
Copy link
Member

ericcurtin commented Jan 28, 2020

Thanks for accepting! I just gave you "Owner" access on that organization(https://github.com/inotify-tools). The last step is to transfer this repo to that organization, in this repos settings:

image

It just enables us to have multiple owners, if that's ok with you?

@ericcurtin
Copy link
Member

We now have two maintainers to avoid single points of failure.

@ericcurtin
Copy link
Member

@cyc1ingsir #104 was merged I'll create a new release in the coming days

@813gan haven't looked at your PR. It's bloody huge! If it breaks backwards compatibility we may not be able to merge.

@carlbordum
Copy link
Contributor

@ericcurtin again, thanks for doing this.

If you're fine with it, I would like to volunteer as well and help you with some of the open issues and prs. Also then, new issues are unlikely to go unanswered.

@bmwiedemann
Copy link
Contributor

When I see things like #109 I'm not so sure anymore... It is always a good thing to have others review code to reduce the likelyhood of introducing errors.

@bmwiedemann
Copy link
Contributor

@ericcurtin I'd really prefer, if you could follow best practices of developing open source software:

  • you should not force push to master (it is only OK to do with a devel / feature branch)
  • write good commit messages
  • do not mix in unrelated changes into commits - makes them easier to understand
  • ask people for code reviews (with over 200 forks there seem to be some people who are familiar with the codebase) - I code for 25+ years and still find reviews very valuable.
  • reference issue IDs in commits/PRs as Fixes #xxx to get automatic cross-links in github

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants