Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin support #67

Open
rvolosatovs opened this issue Jan 4, 2021 · 2 comments · May be fixed by #162
Open

Kotlin support #67

rvolosatovs opened this issue Jan 4, 2021 · 2 comments · May be fixed by #162
Milestone

Comments

@rvolosatovs
Copy link
Owner

Summary

Add Kotlin support. Refs TheThingsArchive/api#43

How do you propose to implement this?

Investigate https://github.com/streem/pbandk

Can you do this yourself and submit a Pull Request?

yes

@rvolosatovs rvolosatovs added this to the Next Up milestone Jan 4, 2021
@rvolosatovs
Copy link
Owner Author

@jpmeijers perhaps you would be interested in contributing to this?
You can see some examples:

@rvolosatovs rvolosatovs modified the milestones: 4.0.0, Backlog Nov 29, 2022
@strophy
Copy link
Collaborator

strophy commented Jan 5, 2023

I researched this for a while and got the build and resulting binary working fine, but I got stuck running it because our target container runs as root, and the way the Kotlin file is made executable using Spring Boot means it will always output a warning if it runs as root: streem/pbandk#73

@rvolosatovs are you familiar with gosu or su-exec? Do you think it makes sense to change our target image to use an unprivileged user to run protoc? We could probably create a user in an entrypoint and set it to the same permissions as the mounted workdir like this? We need to avoid making it a breaking change when doing this, for users that don't set a workdir...

@strophy strophy linked a pull request Feb 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants