-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to alpine 3.20 #341
base: main
Are you sure you want to change the base?
Conversation
e40cf33
to
ada38b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like CI is failing though, could you take a look?
Dockerfile
Outdated
ARG GRPC_WEB_VERSION | ||
RUN curl -sSL https://api.github.com/repos/grpc/grpc-web/tarball/${GRPC_WEB_VERSION} | tar xz --strip 1 -C /grpc-web | ||
RUN git config --global http.version HTTP/1.1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need this? Could you add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is the reason CI is failing. For some reason it works local, but not in GitHub Actions. I'll try to find a way to do this with the tarball instead of git I think, will ping you when CI is passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're just after the source and not a release artifact, https://github.com/grpc/grpc-web/archive/${GRPC_WEB_VERSION}.tar.gz
would get it and is faster than using git, btw.
I am not sure what would happen with submodules - guessing it would not fetch them
Using GitHub API (api.github.com) is tricky and usually requires a token pretty quickly.
just a git clone --recursive
with a tag should work though
f6ea621
to
26ee2dd
Compare
57cfaba
to
7327e0c
Compare
Hi @rvolosatovs finally got around to making the changes needed to support Alpine 3.20. Main changes are: