Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to alpine 3.20 #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update to alpine 3.20 #341

wants to merge 1 commit into from

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Jun 3, 2024

Hi @rvolosatovs finally got around to making the changes needed to support Alpine 3.20. Main changes are:

  • protoc_gen_scala build no longer works on arm64 (I might have a solution for this soon)
  • protoc_gen_ts build is no longer possible due to the end of the pkg project in favour of Node Single Executable Applications. Since this is just the node binary with an additional payload, it is much easier to just include node in the final image and use NPM to install the plugin without complicated build/compile steps.
  • grpc_web build process changed due to Alpine no longer shipping libraries for static linking, so now we need to build protobuf itself first to static link against.
  • re-enable grpc_swift on arm64

Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like CI is failing though, could you take a look?

Dockerfile Outdated
ARG GRPC_WEB_VERSION
RUN curl -sSL https://api.github.com/repos/grpc/grpc-web/tarball/${GRPC_WEB_VERSION} | tar xz --strip 1 -C /grpc-web
RUN git config --global http.version HTTP/1.1 && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we need this? Could you add a comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is the reason CI is failing. For some reason it works local, but not in GitHub Actions. I'll try to find a way to do this with the tarball instead of git I think, will ping you when CI is passing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're just after the source and not a release artifact, https://github.com/grpc/grpc-web/archive/${GRPC_WEB_VERSION}.tar.gz would get it and is faster than using git, btw.
I am not sure what would happen with submodules - guessing it would not fetch them

Using GitHub API (api.github.com) is tricky and usually requires a token pretty quickly.

just a git clone --recursive with a tag should work though

@strophy strophy force-pushed the alpine3.20 branch 7 times, most recently from f6ea621 to 26ee2dd Compare June 9, 2024 12:31
@strophy strophy force-pushed the alpine3.20 branch 6 times, most recently from 57cfaba to 7327e0c Compare June 13, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants