Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the docs to include recent changes in J5 #17

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

nebrius
Copy link
Contributor

@nebrius nebrius commented Sep 18, 2018

Note: the docs here were based on the PR that @dtex did for Raspi IO (nebrius/j5-io#5).

Copy link

@dtex dtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me

@nebrius
Copy link
Contributor Author

nebrius commented Sep 25, 2018

@rwaldron can you merge this when you get a chance? (assuming of course you don't have comments)

README.md Outdated
@@ -126,7 +126,7 @@ Data writing operations must be executed in order of instruction.

#### servoWrite(pin, value)

- Accept a `value` in degrees (0-180) that is written to the specified `pin`.
- Accept a `value` that is written to the specified `pin`. If the value is between 0 and 180, it is assumed to be a servo arm position in degrees. If the value is between 180 and 544, it is also assumed to be in degrees and is truncated to 180. If the value is greater than or equal to 544, it is assumed to be a duty cycle in nanoseconds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nanoseconds/microseconds/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will fix once I’m back at laptop later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nebrius
Copy link
Contributor Author

nebrius commented Nov 15, 2018

@rwaldron @dtex @fivdi ping, any updates for this PR? Are we ready to land it yet?

@dtex
Copy link

dtex commented Nov 15, 2018

I'm still good with it, but don't have the ability to merge.

@rwaldron rwaldron merged commit dd0819f into rwaldron:master Nov 16, 2018
@rwaldron
Copy link
Owner

Eek. Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants