Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Higher board timeout required when using serialport over TCP to connect to a remote board #1053

Closed
mwittig opened this issue Mar 7, 2016 · 4 comments
Closed

Higher board timeout required when using serialport over TCP to connect to a remote board #1053

mwittig opened this issue Mar 7, 2016 · 4 comments

Comments

@mwittig
Copy link
Contributor

mwittig commented Mar 7, 2016

The timeout of 1e4 milliseconds for the board to become ready appears to be too short when using alternative transports, like serialport over TCP to connect to a remote board. See also firmata/arduino#257 (comment)

My suggestion is to make the timeout configurable as part of the board configuration. I have a working fork and I'll be happy to provide a PR for it.

mwittig/johnny-five@d4ced98
@mwittig mwittig changed the title Longer board timeout when using serialport over TCP to connect to a remote board Higher board timeout required when using serialport over TCP to connect to a remote board Mar 7, 2016
@mwittig mwittig mentioned this issue Mar 8, 2016
Merged
@mwittig
Copy link
Contributor Author

mwittig commented Mar 14, 2016

Updated Wiki page https://github.com/rwaldron/johnny-five/wiki/Board

@rwaldron
Copy link
Owner

Nice!

@mwittig
Copy link
Contributor Author

mwittig commented Mar 16, 2016

Landed in 0.9.31

@mwittig mwittig closed this as completed Mar 16, 2016
@rwaldron
Copy link
Owner

Ah, yes. Thank you for following up with the admin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwaldron @mwittig