Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in J5 v0.10.10 ctrl+c doesn't quit when using etherport #1335

Closed
soundanalogous opened this issue May 2, 2017 · 2 comments
Closed

in J5 v0.10.10 ctrl+c doesn't quit when using etherport #1335

soundanalogous opened this issue May 2, 2017 · 2 comments

Comments

@soundanalogous
Copy link

console prints "Board Closing." but doesn't actually quit the application in Mac OS X.

Not sure the exact version where this broke. I upgraded from J5 v0.9.17 (which didn't have this use) to v0.10.10.

Using etherport v0.1.4.

@monteslu
Copy link
Contributor

monteslu commented May 2, 2017

just found this in ble-serial as well. It will probably be a problem in my other virtual serial streams.

This is because of https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L767

Serial streams need to accept the callback and call it on write:
https://github.com/mwittig/etherport-client/blob/master/index.js#L127

@rwaldron
Copy link
Owner

rwaldron commented May 2, 2017

I just updated Etherport: rwaldron/etherport@5a99c57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants