Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial port list throttling and repl error with multiple boards #1456

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Serial port list throttling and repl error with multiple boards #1456

merged 3 commits into from
Apr 5, 2018

Commits on Mar 23, 2018

  1. Serial: throttle serial list attempts, add forced exit 

    When listing available serial connections, a maximum number of 10
attempts every 400 milliseconds are allowed, then the `board.fail`
method is called.
When disconnecting on SIGINT, add a 1000 millisecond timeout before
forcing the exit. This has been added because if one disconnects a
succesfully connected board the process could never exit on SIGINT.
    @dnlup
    dnlup committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    fcf7e1e View commit details
    Browse the repository at this point in the history

  2. Repl: fix multi board disconnection 

    When connecting multiple boards, an exception is thrown when exiting the
process
because `state.board.io.pending` is not defined. This commit fixes the
problem by checking the `length` property of `state.board` and looping
through the board list to check the `board.io.pending` property.
Futhermore, it add a timeout of 1000 milliseconds to force the process
exit in case the `board.io.pending` property never becomes `false` (it
has happened disconnetting a succesfully connected board).
    @dnlup
    dnlup committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    8c88869 View commit details
    Browse the repository at this point in the history

  3. Boards: expose fail event from board items 

    Since `board.fail` is called when connection fails, it might be useful
to echo the event in the Boards class.
    @dnlup
    dnlup committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    0c70eee View commit details
    Browse the repository at this point in the history