New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LED: Add draw examples for 8x8 Matrix, add LED characters file. #852
Conversation
build seems to have failed because I didn't add |
@jorydotcom You'll need to add the example(s) to tpl/programs.json so that they are picked up when |
@Resseguie do we have docs for that somewhere? @jorydotcom make two entries like this: https://github.com/rwaldron/johnny-five/blob/master/tpl/programs.json#L218-L233 but slightly modified to include a re-used breadboard:
You may want to add description, etcβI'll leave the rest for you to sort out. |
|
||
board.on("ready", function() { | ||
|
||
var lc = new five.Led.Matrix({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename lc
=> matrix
Thanks @Resseguie - the LED Matrix breadboard works just fine, I think! Will update momentarily! |
fixes made - should I squash these new commits as well? |
If you feel comfortable doing so, then yes, but otherwise I don't require it |
"description": "Loop through available characters & symbols to see what they look like on a Matrix display.", | ||
"breadboards": [ | ||
{"name": "led-matrix", "title": "LED Matrix breadboard - Arduino Uno"} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Resseguie is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've been out of town this week. I don't have hardware with me to actually test, but the entries above look right at a quick glance.
@rwaldron I don't think so, other than in was PR comments. Perhaps I should do a write-up under contributing guidelines, wiki, and/or a little news blurb about the new structure. Preference where? |
@jorydotcom with the above entry to |
LED: Add draw examples for 8x8 Matrix, add LED characters file.
This is a small update to ledcontrol. It:
π I hope you like it!