Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED: Add draw examples for 8x8 Matrix, add LED characters file. #852

Merged
merged 1 commit into from Jul 19, 2015

Conversation

jorydotcom
Copy link
Contributor

This is a small update to ledcontrol. It:

  • pulls the character constants out of ledcontrol into a new led-chars file.
  • adds a bunch of new characters, symbols, & patterns! πŸ™†β€β™€οΈ
  • adds two new example programs to eg/ so you can play with the matrix characters.

πŸ˜ƒ I hope you like it!

@jorydotcom
Copy link
Contributor Author

build seems to have failed because I didn't add var - will update shortly!

@Resseguie
Copy link
Collaborator

@jorydotcom You'll need to add the example(s) to tpl/programs.json so that they are picked up when grunt examples is run. You can either supply a breadboard specific to the example (and named same as example) or re-use an existing one and specify in the programs.json file). If the other examples there aren't obvious, let me know and I'll help point you in the right direction.

@rwaldron
Copy link
Owner

rwaldron commented Jul 7, 2015

@Resseguie do we have docs for that somewhere?

@jorydotcom make two entries like this: https://github.com/rwaldron/johnny-five/blob/master/tpl/programs.json#L218-L233 but slightly modified to include a re-used breadboard:

    {
        "file": "led-chars-demo.js",
        "title": "LED - Matrix Characters Demo",
        "breadboards": [
          {"name": "led-matrix"}
        ]
    }

You may want to add description, etcβ€”I'll leave the rest for you to sort out.


board.on("ready", function() {

var lc = new five.Led.Matrix({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename lc => matrix

@jorydotcom
Copy link
Contributor Author

Thanks @Resseguie - the LED Matrix breadboard works just fine, I think! Will update momentarily!

@jorydotcom
Copy link
Contributor Author

fixes made - should I squash these new commits as well?

@rwaldron
Copy link
Owner

rwaldron commented Jul 8, 2015

If you feel comfortable doing so, then yes, but otherwise I don't require it

"description": "Loop through available characters & symbols to see what they look like on a Matrix display.",
"breadboards": [
{"name": "led-matrix", "title": "LED Matrix breadboard - Arduino Uno"}
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Resseguie is this ok?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've been out of town this week. I don't have hardware with me to actually test, but the entries above look right at a quick glance.

@Resseguie
Copy link
Collaborator

@Resseguie do we have docs for that somewhere?

@rwaldron I don't think so, other than in was PR comments. Perhaps I should do a write-up under contributing guidelines, wiki, and/or a little news blurb about the new structure. Preference where?

@Resseguie
Copy link
Collaborator

@jorydotcom with the above entry to programs.json, if you run grunt examples it should generate those two new .md files under docs for you. Doing so will verify that your new entries look like you intended. Otherwise, Rick or I can generate them after landing your commits.

@Resseguie
Copy link
Collaborator

@rwaldron re: documenting this workflow, see #860 (I self assigned to knock that out when I'm back in town.)

rwaldron added a commit that referenced this pull request Jul 19, 2015
LED: Add draw examples for 8x8 Matrix, add LED characters file.
@rwaldron rwaldron merged commit cf6921b into rwaldron:master Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants