add suggested constants to index.js #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements rwaldron#5 τ implements rwaldron#14 φ etc.
rwaldron
reviewed
Sep 10, 2020
reference-implementation/index.js
Outdated
| defineMath("WEST", Math.EAST * 3); | ||
| defineMath("WNW", Math.NNE * 13); | ||
| defineMath("NW", Math.NE * 7); | ||
| defineMath("NNW", Math.NNE * 15); |
There was a problem hiding this comment.
I think it will be very hard to make the case for lines 26-53. If you can remove those, I will merge this.
There was a problem hiding this comment.
I plan to add this proposal to the agenda for the next meeting.
There was a problem hiding this comment.
Was this ever put on a meeting agenda?
as requested in review
|
@rwaldron I removed the questionable angles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #5 τ
implements #14 φ etc.