Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop decoding unknown datatype #30

Closed
jbardin opened this issue Oct 28, 2014 · 3 comments
Closed

Infinite loop decoding unknown datatype #30

jbardin opened this issue Oct 28, 2014 · 3 comments

Comments

@jbardin
Copy link
Contributor

jbardin commented Oct 28, 2014

I have another crashing image.

When decoding the exif tags, we end up in an infinite loop decoding the following tags:

t.Type:1 valLen:164 t.Count:164 t.ValOffset:0
t.Type:20 valLen:0 t.Count:144 t.ValOffset:0
t.Type:1 valLen:164 t.Count:164 t.ValOffset:0
t.Type:20 valLen:0 t.Count:144 t.ValOffset:0
@jbardin
Copy link
Contributor Author

jbardin commented Oct 28, 2014

I can add a patch into PR #29 if it's OK, since I have another jpg to add to ./exif/corrupt

@rwcarlsen
Copy link
Owner

sure.

On Tue, Oct 28, 2014 at 10:35 AM, James Bardin notifications@github.com
wrote:

I can add a patch into PR #29
#29 if it's OK, since I have
another jpg to add to ./exif/corrupt

—
Reply to this email directly or view it on GitHub
#30 (comment).

@jbardin jbardin mentioned this issue Oct 28, 2014
Merged
rwcarlsen added a commit that referenced this issue Dec 22, 2014
@rwcarlsen
more careful handling of offsets and memory. fixes #20 and #30. Thanks …
41dad3a 
…@jbardin
@rwcarlsen
Copy link
Owner

fixed in 41dad3a.

@hullerob hullerob mentioned this issue Mar 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbardin @rwcarlsen