-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds mknote package #12
Conversation
The one incompatible change is that the ImageLength field name has been corrected to ImageHeight.
Most known fields in Nikon and Canon maker notes are now parsed. The Canon maker not support still needs a better way of passing the offset to the maker note in the EXIF file to the maker note parser. Other makers need to be added.
Usage example: ...
f, err := os.Open(fname)
if err != nil {
log.Fatal(err)
}
x, err := exif.Decode(f)
if err != nil {
log.Fatal(err)
}
_, err := mknote.Decode(x)
if err != nil {
log.Fatal(err)
}
owner, _ := x.Get(mknote.OwnerName)
... |
Except it needs a better name than DecodeFile. |
I added a commit to the pull request I started, #11 , to do registration as I described. I'm not completely happy with the several conversions that it takes to add to the list of valid fields, but I suppose it's not too terrible. That could be reworked a bit at some point. |
I think the validField check should probably just be removed. If we allow exif package users to load custom fields into the exif structure anyway (LoadDirTags), than anything could be a valid field. |
…LoadDirTags). made unexported field maps specified using constants
…nd nikon makernote parsers. exifstat has mknote flag
Thanks @gsadams!