Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a panic that can be caused by bad input data #49

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Oct 14, 2016

Found this panic using go-fuzz.

Relevant panic output was:

panic: runtime error: index out of range

goroutine 1 [running]:
github.com/rwcarlsen/goexif/exif.(*parser).Parse(0xb0c2b0, 0xc4200161b0, 0xc4200161e0, 0x0)
github.com/rwcarlsen/goexif/exif/exif.go:147 +0x4c5
github.com/rwcarlsen/goexif/exif.Decode(0xac2ba0, 0xc420016090, 0xc42054fab8, 0x1051e, 0xc420016090)
github.com/rwcarlsen/goexif/exif/exif.go:287 +0x6ea
[...]

I can provide the input that triggered the crash if required.

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 18, 2016

resolves #39

@xor-gate
Copy link

xor-gate commented Jan 8, 2017

@ssoroka It seems the author is not very active in this project anymore, many forks have been created. I would like to make this stable and I created goexif2 which integrates your patch: xor-gate@c654e02

@rwcarlsen rwcarlsen merged commit 839e318 into rwcarlsen:go1 Mar 18, 2019
hmage pushed a commit to hmage/goexif that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants