Skip to content

Commit

Permalink
Added some notes about fixing JavaScript
Browse files Browse the repository at this point in the history
Our copy of Prototype is so old that it won't work correctly with the
code generated by *.rjs.  But some of the stuff in application.js is
incompatible with newer versions of Prototype.

Fixing this is going to require testing all the JavaScript-enabled
controllers by hand.
  • Loading branch information
emk committed Dec 24, 2008
1 parent 975d51b commit 33d3130
Showing 1 changed file with 10 additions and 28 deletions.
38 changes: 10 additions & 28 deletions RAILS-2.2-TODO.txt
Expand Up @@ -13,36 +13,18 @@ release based on Rails 2.2.
Make sure we know what's up with plugins
We need to review our TODO comments

== Security
== Fixing JavaScripts

Our JavaScripts are actually pretty broken, and have been for a while.

We need to do a basic security audit.
Update to latest Prototype
Fix admin/articles
Fix admin/assets
Test other controllers for breakage

== Security

/ Cookies
X Can we restrict admin cookies to /admin ? No--need /accounts, too.
/ Make sure logging out clears all relevant cookies and tokens
/ Check for session fixation attacks
/ Make sure cookies are HTTP-only whenever possible
/ Cross-site scripting
/ Turn on protect_against_forgery
/ Check all fields in comments
/ It looks like the failed comment error form has issues
/ Fix comment submission form to not use mass assignment
/ Check macro:* bodies and parameters
/ Make sure comment output is properly sanitized in any case
/ filtered_column_code_macro
/ filtered_column_flikr_macro - lots of issues
/ Do we have trackback support to check? No.
/ Password change
/ Verify token required to change e-mail and password
/ Everything else
/ Don't ship :session_key in environment.rb!
/ Do we need to override verifiable_request_format? No.
/ Check redirection in lib/authenticated_system.rb
/ Review mass assignment in public controllers - comments
/ Check regexes for ^ and $
/ Filter IMG tags
/ Block database updates on POST requests
/ Review http://guides.rubyonrails.org/security.html again
Here's a list of remaining security work:

Admin only
For now, we'll assume that users with access to /admin don't try XSS
Expand Down

0 comments on commit 33d3130

Please sign in to comment.