Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't draw asterisks in subtitles #510

Merged
merged 3 commits into from
Jun 9, 2018

Conversation

NFSMONSTR
Copy link
Contributor

img

In English version GTA 3 some subtitles missing and replaced with asterisks, which original game don't draw

@JayFoxRox
Copy link
Collaborator

I wonder if this change is such a good idea. It is a logic change as part of the renderer.
If this change is bad, it might be hard to track down what causes bugs in the future.
This change could lead to text not appearing when it should, and it might be difficult to tell that text is even missing. This might result in confusing game dialog / logic which could accidentally be blamed on something else.

Do we know that this game handles this the same way?
What about strings like " * " (are spaces still drawn? with the textboxes it would change the size) or "foo*bar" (will it display as "foo", "foo bar", ...)

So I'm wondering if we should break, continue, if (str == "*") { return; } or maybe something entirely different.

If you can't be bothered to check what the original game does (or at least some testing with the original game), I'd suggest creating an easy-to-find issue about this, so we consider it an option when problems arise.

@ghost
Copy link

ghost commented Jun 8, 2018

return would be better https://pastebin.com/d3EQ155N

@NFSMONSTR
Copy link
Contributor Author

NFSMONSTR commented Jun 8, 2018

You right. The game really checks only the first char. My bad

That how looks "foo*bar" in game:
img

UPD:
Help messages it the up left corner works the same way as subtitles

@@ -141,6 +141,9 @@ void TextRenderer::setFontTexture(int index, const std::string& texture) {

void TextRenderer::renderText(const TextRenderer::TextInfo& ti,
bool forceColour) {
if ((ti.text.empty()) || (ti.text[0] == '*'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the unnecessary parens?

@darkf darkf merged commit 85785b0 into rwengine:master Jun 9, 2018
NFSMONSTR added a commit to NFSMONSTR/openrw that referenced this pull request Jun 18, 2018
Don't draw asterisks in subtitles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants