-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't draw asterisks in subtitles #510
Conversation
I wonder if this change is such a good idea. It is a logic change as part of the renderer. Do we know that this game handles this the same way? So I'm wondering if we should If you can't be bothered to check what the original game does (or at least some testing with the original game), I'd suggest creating an easy-to-find issue about this, so we consider it an option when problems arise. |
|
rwengine/src/render/TextRenderer.cpp
Outdated
@@ -141,6 +141,9 @@ void TextRenderer::setFontTexture(int index, const std::string& texture) { | |||
|
|||
void TextRenderer::renderText(const TextRenderer::TextInfo& ti, | |||
bool forceColour) { | |||
if ((ti.text.empty()) || (ti.text[0] == '*')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the unnecessary parens?
Don't draw asterisks in subtitles
In English version GTA 3 some subtitles missing and replaced with asterisks, which original game don't draw