Remove sysdata.rda

* remove unessesary sysdata.rda * update tests * update cran-comments
rwetherall · Jul 19, 2019 · e18b03c · e18b03c
1 parent 0f175ad
commit e18b03c
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: alfr
 Type: Package
 Title: Connectivity to 'Alfresco' Content Management Repositories
-Version: 1.3.0.9000
+Version: 1.2.1.9000
 Author: Roy Wetherall <rwetherall@gmail.com>
 Maintainer: Roy Wetherall <rwetherall@gmail.com>
 Description: Allows you to connect to an 'Alfresco' content management repository and interact

diff --git a/R/sysdata.rda b/R/sysdata.rda
diff --git a/cran-comments.md b/cran-comments.md
@@ -7,3 +7,7 @@
 
 0 errors | 0 warnings | 0 note
 
+## Notes
+
+v 2.1.1 removes sysdata.rda as was assumed cause of warnings seen [here](https://CRAN.R-project.org/web/checks/check_results_alfr.html)
+
diff --git a/tests/testthat/resources/testdoc.txt b/tests/testthat/resources/testdoc.txt
diff --git a/tests/testthat/resources/testuploaddoc.txt b/tests/testthat/resources/testuploaddoc.txt
diff --git a/tests/testthat/testalf_session.R b/tests/testthat/testalf_session.R
@@ -3,6 +3,8 @@ context("alf-session")
 require(magrittr)
 require(httptest)
 
+invalid_ticket <- "TICKET_b1433bd56ba762daeec869f6e6d8d2578c463689"
+
 mocked_test_that(
 
   "Given a valid respository,
@@ -44,7 +46,9 @@ mocked_test_that(
    When I check it is valid,
    Then I am told that it is", {
 
-  expect_false(alf_session.is_valid(alf_sample.invalid_session))
+  session <- alf_session(test_server, admin_username, admin_password)
+  session$ticket <- invalid_ticket
+  expect_false(alf_session.is_valid(session))
 })
 
 mocked_test_that(
@@ -64,6 +68,8 @@ mocked_test_that(
    When I invalidate the session,
    Then nothing happens", {
 
-  result <- alf_session.invalidate(alf_sample.invalid_session)
+  session <- alf_session(test_server, admin_username, admin_password)
+  session$ticket <- invalid_ticket
+  result <- alf_session.invalidate(session)
   expect_false(result)
 })