40k: move rest of 10th rendering to tsx #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move rest of 40k 10th rendering to tsx, namely removing explicit calls to document.createElement(). Common files, like for rendering options, are untouched. Those functions require passing in parent component and then adding DOM to that, whereas with the tsx code we're writing, we want functions to return DOM nodes that are then added to parent components by the caller. In future, we could update those common files, but it's lo pri and I'm keen to leave them alone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move rest of 40k 10th rendering to tsx, namely removing explicit calls to document.createElement().
Common files, like for rendering options, are untouched. Those functions require passing in parent component and then adding DOM to that, whereas with the tsx code we're writing, we want functions to return DOM nodes that are then added to parent components by the caller.
In future, we could update those common files, but it's lo pri and I'm keen to leave them alone