Minijinja2: Improve error reporting #2784
Open
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioBenitez
force-pushed
the
minijinja-improved-error-reporting
branch
from
a956454
to
ee78062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the error reporting for Minijinja2 templates.
Currently, when errors occur in a Minijinja2 template, it usually gives an error message that only has a top-level explanation of the problem. When the issue comes from an included file or a layout, this error message does not include enough details to diagnose the problem when the problem.
With this change, it now prints details about the entire error chain returned, which acts as a stack trace to find the cause of the error.
It also adds the error message on 'template not found' errors.