Add MiniJinja for templating example #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-an
commented
May 28, 2024
|
Awesome! Please see the build failures. Will review once the CI is green. |
va-an
force-pushed
the
add-minijinja-example
branch
from
d4e0f71
to
1c1af5d
Compare
Found and fixed issues with line length and whitespaces. Now |
va-an
force-pushed
the
add-minijinja-example
branch
2 times, most recently
from
3eebc61
to
6f883e3
Compare
|
Added mention of MiniJinja to the guide. Force-pushed to delete files added by mistake. |
the10thWiz
reviewed
Jun 26, 2024
|
@the10thWiz Can you finalize this PR and then squash + rebase + reword and merge? |
the10thWiz
force-pushed
the
add-minijinja-example
branch
from
6f883e3
to
75a424d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that support for MiniJinja has been added in the new version of
rocket_dyn_templates, and I have added a corresponding example.