Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example code in README.md by applying the following compiler … #780

Closed
wants to merge 1 commit into from
Closed

Conversation

NAThompson
Copy link

…suggestion:

error[E0658]: procedural macros cannot be expanded to expressions (see issue #38356)
--> src/main.rs:12:38
|
12 | rocket::ignite().mount("/hello", routes![hello]).launch();
| ^^^^^^^^^^^^^^
|
= help: add #![feature(proc_macro_non_items)] to the crate attributes to enable

…suggestion:

error[E0658]: procedural macros cannot be expanded to expressions (see issue #38356)
  --> src/main.rs:12:38
   |
12 |     rocket::ignite().mount("/hello", routes![hello]).launch();
   |                                      ^^^^^^^^^^^^^^
   |
   = help: add #![feature(proc_macro_non_items)] to the crate attributes to enable
@NAThompson
Copy link
Author

This appears to only show up on the very latest rustc: I reproduced with

$ rustc --version
rustc 1.31.0-nightly (fc403ad98 2018-09-30)

and a few days ago, this was not a compile error.

@SergioBenitez
Copy link
Member

It's not rustc that's changed, it's Rocket; we're now using procedural macros for more things than before, requiring different feature gates, and we haven't updated the README or guide docs appropriately. There's a final major change I'm working on now that will fix the README as well, but I'm waiting on rust-lang/rust#52121 to land, which will change the feature gates yet again.

@NAThompson
Copy link
Author

Ok, cools, looks like that PR will render this one irrelevant, so this is a non-issue.

@NAThompson NAThompson closed this Oct 1, 2018
@SergioBenitez SergioBenitez added the pr: closed This pull request was not merged label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: closed This pull request was not merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants