Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RustCrypto dependencies #174

Closed
wants to merge 1 commit into from

Conversation

tarcieri
Copy link
Contributor

@tarcieri tarcieri commented May 3, 2021

Updates the following RustCrypto dependencies to the latest versions:

  • aes-gcm v0.9.0
  • hmac v0.11.0
  • hkdf v0.11.0

Updates the following RustCrypto dependencies to the latest versions:

- `aes-gcm` v0.9.0
- `hmac` v0.11.0
- `hkdf` v0.11.0
@tarcieri
Copy link
Contributor Author

tarcieri commented May 3, 2021

Heads up: the RUSTEC-2021-0059 and RUSTSEC-2021-0060 unmaintained crate advisories will likely apply to current users of cookie-rs until these dependencies are updated, in case you start getting reports.

@SergioBenitez
Copy link
Member

Thank you for keeping the libs updates. I really appreciate your effort here.

Merged in 14b053a.

@SergioBenitez
Copy link
Member

@tarcieri It looks like aes has a new MSRV. Previously, it compiled just fine on 1.41. Now, I'm getting the following:

error[E0658]: unions with non-`Copy` fields are unstable
   --> aes-0.7.0/src/autodetect.rs:30:13
    |
30  | /             pub(super) union Inner {
31  | |                 pub(super) ni: ManuallyDrop<crate::ni::$name>,
32  | |                 pub(super) soft: ManuallyDrop<crate::soft::$name>,
33  | |             }
    | |_____________^
...
125 |   define_aes_impl!(Aes128, aes128, U16, "AES-128 block cipher instance");
    |   ----------------------------------------------------------------------- in this macro invocation
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/55149

Any chance MSRV could be pushed back to 1.41?

@tarcieri
Copy link
Contributor Author

tarcieri commented May 4, 2021

@SergioBenitez with the force-soft feature, the MSRV of the aes crate is still 1.41+.

I now realize there's no corresponding force-soft feature for the aes-gcm crate itself though. I could potentially add that if you'd like to keep MSRV at 1.41.

@tarcieri tarcieri deleted the bump-rustcrypto-deps branch May 4, 2021 13:12
@SergioBenitez
Copy link
Member

@SergioBenitez with the force-soft feature, the MSRV of the aes crate is still 1.41+.

I now realize there's no corresponding force-soft feature for the aes-gcm crate itself though. I could potentially add that if you'd like to keep MSRV at 1.41.

While it's debatable whether MSRV should be part of semver or not, I'd like to be conservative here and not break MSRV in a minor point release, so this would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants