Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the 'maven { url 'http://dl.bintray.com/asciidoctor/maven/' }' extensions for? #1

Closed
marceloverdijk opened this issue Dec 12, 2014 · 3 comments

Comments

@marceloverdijk
Copy link

Hi @rwinch,

This is very interesting setup to generate asciidoc documentation I will be borrowing :-)

I only wonder why this is needed in build.gradle:

// necessary only until jcenter contains the extensions
maven { url 'http://dl.bintray.com/asciidoctor/maven/' }

I tried without this and then the generated docs look different (styling) but the do generate.
so I wonder how this works?

rwinch pushed a commit that referenced this issue Dec 12, 2014
there were some issues propagating to the asciidoctor release
into jcenter() and the release was found in that private repo
sooner.

Now that it is in jcenter() the line should be able to be
removed.

Issues: gh-1
@rwinch
Copy link
Owner

rwinch commented Dec 12, 2014

@marceloverdijk Thanks for the feedback :)

I only wonder why this is needed in build.gradle:

That line was only necessary because there were some issues propagating to the asciidoctor release into jcenter() and the release was found in that private repo sooner. Now that it is in jcenter() the line should be able to be removed.

In light of this, I cleaned up the build to only have jcenter() now.

I tried without this and then the generated docs look different (styling) but the do generate.
so I wonder how this works?

I am not certain why it is different. When I look at my very basic example it looks the same (although I don't have a keen eye for these things). Can you point out what is different? AFAIK..it should be the same.

@marceloverdijk
Copy link
Author

Hmm, yes it works as expected now.
It's rather strange as I tried earlier without this extension maven repo, and hen I noticed I got some different font and highlighjs code blocks were not styled.
I noticed it only once and I cannot reproduce it anymore.

Thanks for your reply. I will close the issue.

@rwinch
Copy link
Owner

rwinch commented Dec 12, 2014

No problem and thanks for the follow up. Just a thought...perhaps it was due to issues with the CDN serving some of the static resource (i.e. highlighjs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants