Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected '@' messages from jshint #69

Closed
ianpetzer opened this issue Jul 4, 2016 · 5 comments
Closed

Unexpected '@' messages from jshint #69

ianpetzer opened this issue Jul 4, 2016 · 5 comments

Comments

@ianpetzer
Copy link

Hi there,

I've read some other issues on this repo about JSHint not support annotations as they are still a stage 1 proposal.

I was just wondering what we should do in order to use the annotations and not get failures in our build. Is the best solution to migrate to Eslint instead of JSHint?

Thanks for any advice!

@ianpetzer
Copy link
Author

I've got advice on ember slack community to change to ESLint.

@rwjblue
Copy link
Contributor

rwjblue commented Jul 4, 2016

Yes, replace ember-cli-jshint with ember-cli-eslint. You can use polyjuice to help migrate you custom JSHInt config.

@rwjblue rwjblue closed this as completed Jul 4, 2016
@ianpetzer
Copy link
Author

Thanks so much for the advice!

@linearza
Copy link
Contributor

linearza commented Jul 4, 2016

@rwjblue Hi! We have mostly succesfully converted to eslint, I just have one question, im struggling to get anything in the format of @reads('someProp') undefineProp,, be that @mapBy, or @alias etc. to pass as defined variables, where eslint errors out on no-undef - do you perhaps know of a solution?

@ianpetzer
Copy link
Author

This might help #59 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants