Refining types for waiter-manager #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
May 24, 2019
| @@ -4,7 +4,7 @@ export type Token = unknown; | |||
| export interface IWaiter { | |||
| name: WaiterName; | |||
| waitUntil(): boolean; | |||
| debugInfo(): unknown; | |||
| debugInfo(): ITestWaiterDebugInfo[]; | |||
There was a problem hiding this comment.
I'd rather the generic thing not be forced into the same structure as what TestWaiter would use.
There was a problem hiding this comment.
I thought about this too, but from a consumer standpoint, we expect to output this debug info as part of @ember/test-helpers. Specifically, that library does expect this to be a particular format. In fact, it exactly expects this format, as demonstrated here. How would we handle this otherwise?
There was a problem hiding this comment.
Kk, seems good then. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types in
waiter-manager.tswere a little loose. This PR tightens them up a bit.