Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure custom changelog is displayed initially on release-it@13.5.3+. #38

Merged
merged 1 commit into from Apr 20, 2020

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Apr 20, 2020

This works around the issue described in release-it/release-it#647 by leveraging plugin.getLatestVersion hook to override the global config's changelog value.

This sort of race is unfortunate, and we really should determine a better way to provide our functionality that is not brittle to changes in release-it.

@rwjblue rwjblue added the bug Something isn't working label Apr 20, 2020
@rwjblue rwjblue changed the title Ensure custom changelog is displayed initialy on release-it@13.5.3+. Ensure custom changelog is displayed initially on release-it@13.5.3+. Apr 20, 2020
@rwjblue rwjblue merged commit 3a99b3c into master Apr 20, 2020
@rwjblue rwjblue deleted the ensure-custom-changelog-is-shown branch April 20, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant