Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto download host's mods on join #41

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Conversation

Nebual
Copy link
Member

@Nebual Nebual commented Apr 1, 2020

Adds a new button to the 'Mod definition mismatch' window that appears when a guest joins a host with differing mods enabled: "Autosync Mod List". It will:

  • Subscribe to any Workshop mods the host currently has active, waiting for their downloads/installs to complete
  • Set the list of active mods to match the host's, including order. This is functionally equivalent to automating the copying of ModsConfig.xml

Caveats:

  • it doesn't download non-workshop versions of mods. If they're installed out-of-band, this will still correctly activate them in ModsConfig.xml, so that's something!
  • it'll display a console error if Workshop cannot be reached, such as for non-Steam installs, and proceed to try setting up ModsConfig. Missing mods are just ignored/not-set.

I expect this to personally save me 60+ minutes of handholding my friends through the manual sync process :D

@notfood
Copy link
Member

notfood commented Apr 1, 2020

Without config sharing, this option will only cause trouble to the average user. They'll expect for it to just work but in reality they'll just desync.

Some configs are local, others are multiplayer required. Perhaps some config panel where you select what config files are required. Then there is the issue with some mods not storing their config in the expected location (hugslib I'm looking at you)

@Deathlymad
Copy link

Would it maybe make sense to shift dealing with the configs in some complex way to the multiplayer API and assume a default? Also maybe have mods register a mirror that defaults to their steam workshop.

@notfood
Copy link
Member

notfood commented Apr 17, 2020

I'd like to make some UI for file blacklisting picked from the Mod.Settings()

@notfood notfood merged commit e5b94c4 into rwmt:wip-1.1 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants