cmake file api #10
Merged
cmake file api #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rwols
commented
Oct 6, 2019
•
rwols
commented
- trim fat from this plugin
- use the new file api, requires cmake 3.15
- modernize vcvarsall.bat handling for windows, deprecate vs2013 and older
- allow any "Visual Studio x yyyy" generator string
- account for platform for generators
- account for toolset for generators
- make a migration path for old settings, e.g. target_architecture --> platform, visual_studio_versions --> vs_major_version
This was referenced Oct 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.