Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All properties and methods which can thow an NotSupportedException must be marked as obsolete. #47

Closed
jhorsman opened this issue Mar 2, 2017 · 3 comments
Milestone

Comments

@jhorsman
Copy link
Contributor

jhorsman commented Mar 2, 2017

When using a mocking framework in tests it is really annoying to get those exceptions when the mocking framework just tries to populate the model with test data ;)

To avoid this, make sure to annotate everything that can thow a NotSupportedException as [Obsolete].

Maybe it is worth having a script checking for this.

@jhorsman
Copy link
Contributor Author

jhorsman commented Mar 2, 2017

Fixed a few occurences, see #46

@rpannekoek rpannekoek added this to the v2.0 milestone Mar 7, 2017
@rpannekoek
Copy link
Contributor

The "problem" is that for some properties, only the setter is obsolete (and throws NotSupportedException), but it is not possible to mark only a property setter as obsolete. These setters will be removed in DXA 2.0 as part of deprecated API cleanup.

TSI-878 (Internal issue ID for tracking purposes)

@rpannekoek
Copy link
Contributor

Fixed in DXA 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants