Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing Obsolete decoration on PageBase #46

Closed
wants to merge 2 commits into from
Closed

Adding missing Obsolete decoration on PageBase #46

wants to merge 2 commits into from

Conversation

jhorsman
Copy link
Contributor

@jhorsman jhorsman commented Mar 2, 2017

The PageBase.Id property thows an exception, it should be marked as Obsolete.

@jhorsman jhorsman mentioned this pull request Mar 2, 2017
Closed
@jhorsman
Copy link
Contributor Author

jhorsman commented Mar 2, 2017

Added a few more [Obsolete("Deprecated in DXA 1.1.")] decorations.

rpannekoek
rpannekoek reviewed Mar 6, 2017
View reviewed changes
Copy link
Contributor

@rpannekoek rpannekoek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the IContentResolver is deprecated as a whole.
The Id and Name properties are NOT deprecated, only the setters are.
Both are scheduled to be removed completely in DXA 2.0 (as part of cleaning up deprecated APIs).

@rpannekoek
Copy link
Contributor

Obsolete APIs are removed in DXA 2.0 code base.

@rpannekoek rpannekoek closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpannekoek rpannekoek rpannekoek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhorsman @rpannekoek