Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized algorithm output log #68

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

beka-zhvania
Copy link
Contributor

No description provided.

@beka-zhvania beka-zhvania added this to To do in WebOCD via automation Apr 11, 2022
@beka-zhvania beka-zhvania linked an issue Apr 11, 2022 that may be closed by this pull request
@MaxKissgen MaxKissgen self-requested a review April 11, 2022 11:21
Copy link
Contributor

@MaxKissgen MaxKissgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should do this with a printLn statement and rather use one of our loggers. Otherwise we definitely dont have it in WebOCDs logs for later viewing. Whats your opinion on that?

On another note, I think the Ant algorithm still prints its modularity apart from the final output. I'll double check the other files as well just to be sure

@beka-zhvania
Copy link
Contributor Author

The point of this was to standardize console output since it differed among algorithms. But yeah, it makes more sense to use a logger and actually do it directly from the Serviceclass when calling the algorithm. I'll change that

@MaxKissgen MaxKissgen changed the title Standardized algorithm output log WIP: Standardized algorithm output log Apr 11, 2022
@MaxKissgen MaxKissgen marked this pull request as draft April 11, 2022 12:12
@MaxKissgen MaxKissgen changed the title WIP: Standardized algorithm output log Standardized algorithm output log Apr 11, 2022
@beka-zhvania
Copy link
Contributor Author

Issues with logging

  1. Logging number of communities found from within the service class (runAlgorithm method) requires waiting for the algorithm execution to finish, which would result in unnecessary blocking.
  2. using L2pLogger only makes sense from within a service class, so using it from detectOverlappingCommunities method of OCD algorithms is not viable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
WebOCD
  
To do
Development

Successfully merging this pull request may close these issues.

Standardize output logs of algorithms
3 participants