Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/1.3.3 #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Releases/1.3.3 #108

wants to merge 3 commits into from

Conversation

lakhoune
Copy link
Member

@lakhoune lakhoune commented Oct 20, 2023

Pull Request Summary

This pull request introduces a critical fix that addresses the issue of outdated backupped models being submitted to the Bot Manager service. The previous implementation was using outdated data, causing inconsistencies in the service. In this update, we've revamped the process, directly leveraging the syncmeta function to retrieve the JSON version of the model, ensuring data accuracy and consistency.
Also see the changes at https://github.com/rwth-acis/syncmeta/releases/tag/2.4.9

Changes Made

  • Implemented a new approach to fetch model data using the syncmeta function.
  • Resolved the issue of submitting outdated backupped models to the Bot Manager service.

How to Test

  1. Make sure the environment is set up and running.
  2. Deploy this PR to your environment.
  3. Verify that the Bot Manager service now correctly uses the JSON version of the model obtained from the syncmeta function. You can do this by inspecting the payload of the post request that is being sent when clicking on Submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant