New Feature: Drag and Drop System #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used later to highlight Issue when it overlaps with Visualization
Most parts copied or modified from overlapTestMethods Branch -DragAndDrop Component added Component saves all visualizations that currently overlap the Issue. If the Issue is let go, it is added to the Visualizations -variables added for functionality: wait before drop registered -Test Scene added that shows Drag and Drop functionality -Test Script added for Scene that spawns Issue cards
…sualizations Drag and drop/drop issues into visualizations
done to prevent possible issue of the trigger component overlapping with the Bounding Box of the manipulation component. Also enforces a "real" overlap with more than a tiny corner of the Issue
What the comment above the code says doesn't fit what the code does. The code also basically says if component doesn't exist, delete it, which doesn't make sense
The Issue card is destroyed with a fancy animation which shows to which visualization it is added. currently only one of the potentially multiple visualizations is shown as the target. For more visualizations, the issue card would have to be duplicated.
A line indicates which visualizations currently overlap with the issue to give the user more feedback on where he is about to add the issue. If only one visualization overlaps, the indicator on the issue is enough.
The issue card will only be considered for dropping when it is below a certain speed. This way, accidental dropping while moving an issue card is less likely
Drag and Drop Removed highlighting bug while moving visualizations and others
Drag and Drop Implemented Overlap Indicator feature
…ative Drag and Drop Speed condition functionality fully implemented
Drag and Drop delete issues after adding them
Drag and Drop now also works outside the test scene The Competence Display needs a collider for DandD to work. As the Bounding Box collider is fitted at runtime though, the new collider has to be too, because it needs to be smaller than the BB collider while also being (nearly) as big as the whole component
updated copymover.cs to implement feature
Fixed bug: tried to stop coroutine even if it wasnt started
…es-from-testscene-into-project Drag and drop integrated features into project and cleanup
Issue card in kanban board should only be deleted if an issue card really was created
…om-kanbanboard cards now get removed from kanban board when dragging issue out
As the size of the component can change with each UpdateView, the size of the Drag and Drop collider has to change, too.
Bug Fixed: Hitbox of Drag and Drop is moved when view is updated Bug Fixed: Adding Issue without opening menu results in update error
Drag and drop/develop
PaulMWeiser
changed the title
|
The minor fixes are merged. Changes on Photon Voice-related codes are only a walkaround for the namespace error and may not be merged into the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly Added Feature
A drag and drop system that enables the user to add an issue to a visualization not using the cumbersome menu inside but by grabbing it and letting go while the issue overlaps with the visualization. This is a more intuitive way, as confirmed by our feature testers.
There are multiple subfeatures that aim to make the system as user friendly as possible:
Overlap Indicators
While the issue overlaps with a visualization, it is highlighted. If it overlaps with at least two visualizations, it also indicates that by drawing a line to each overlapping visualization
Issue Cart Deletion After Drop
When the issue is dropped over a visualization, it is deleted. To show the user that that is intended behavior, the deletion involves an animation where the issue is "dragged into" the visualization it is added to (only into one, if multiple overlapping)
preventing accidental drops
An overlap is only registered if the issue card is below a certain speed. This way, if the user just wants to move the issue, he cannot accidentally drop it into a visualization
dragging issues out of Kanban Boards
Dragging an issue out of a Kanban Board is already possible without this feature. Now, if an issue is dragged out, it is removed from the Kanban Board. This makes it easier for users to move issues between Kanban Boards (e.g. from "open" to "in progress").