Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub5ScoreJob: improvement #293

Open
christophmluscher opened this issue Jul 25, 2022 · 1 comment
Open

Hub5ScoreJob: improvement #293

christophmluscher opened this issue Jul 25, 2022 · 1 comment
Assignees
@curufinwe @christophmluscher @michelwi

Comments

@christophmluscher
Copy link
Contributor

why are we copying ref and hyp? from the code this is not clear to me. can we remove the copying step??

https://github.com/rwth-i6/i6_core/blob/main/recognition/scoring.py#L246

https://github.com/rwth-i6/i6_core/blob/main/recognition/scoring.py#L252

Originally posted by @christophmluscher in #292 (comment)
@christophmluscher christophmluscher mentioned this issue Jul 25, 2022
Merged
@christophmluscher
Copy link
Contributor Author

@curufinwe @michelwi I would like your feedback on this. I would do the following pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curufinwe curufinwe

@christophmluscher christophmluscher

@michelwi michelwi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@curufinwe @christophmluscher @michelwi