Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp3/Ogg files support instead of midi instruments #3

Open
rwtnb opened this issue Mar 18, 2023 · 3 comments
Open

Mp3/Ogg files support instead of midi instruments #3

rwtnb opened this issue Mar 18, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rwtnb
Copy link
Owner

rwtnb commented Mar 18, 2023

Playing with the actual song mp3 instead of midi instruments? You then could even use one of those apps/libraries that split a song into different tracks using magic and mute the drums? Syncing notes to audio might be an issue there though.

@rwtnb rwtnb added the enhancement New feature or request label Mar 18, 2023
@rwtnb rwtnb changed the title mp3/ogg file support instead of midi instruments Mp3/Ogg files support instead of midi instruments Mar 18, 2023
@Punkoivan
Copy link

To sync the notes we can test next case:

  1. Load mp3/ogg
  2. Convert it to midi
  3. Play mp3 while use midi for notes

The problem is in point 2 - mp3/ogg to midi is not easy thing and would require few tool.
Like lalala.ai to extract drums and then another tool to convert drum to midi.
I've used few online solution to convert mp3 to midi and with vocal the result is garbage. So need to remove vocal first I guess.

@rwtnb
Copy link
Owner Author

rwtnb commented Mar 24, 2023

I was thinking about: https://github.com/deezer/spleeter

Audio quality must not be a big issue, since most people would prefer to have the drums louder than the backing track, I think.
But I'm don't like the idea of implementing it inside Drumsthesia, besides it is written in python it would be an ugly solution trying to integrate both.
It would be way cooler if it was implemented as a webapp, where people could share pre-synced midi/drumless audio files, must think about if there is any legal issues here.
But if we don't store the files it should be ok, until we figure it out.

Basically, the webapp would:

  • Split the tracks
  • Merge it again excluding the drums
  • Use the isolated drum track to predict when the drum part starts
  • Try to match it automatically against the user provided midi track, but giving the user an option to fine tune it
  • Export a GZIP file with both mid/mp3 plus a metadata file with timing data.

In Drumsthesia, we would just check the file type and play it.

@rwtnb
Copy link
Owner Author

rwtnb commented Mar 24, 2023

You know what, a simple CLI would do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants