Permit configuring maximum number of seconds to wait for test command #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmarks:
Fuzz result sizes:
|
michaelglass
previously approved these changes
May 30, 2023
Adds a `--startup-timeout-seconds` flag (and `ABQ_STARTUP_TIMEOUT_SECONDS` env var) to configure the maximum amount of time to wait for the native test process to startup.
Co-authored-by: Michael Glass <me@mike.is>
ayazhafiz
force-pushed
the
configure-abq-protocol-version-timeout
branch
from
fabf9ab
to
e97944b
Compare
| @@ -3924,7 +3924,7 @@ fn kill_on_early_startup_timeout_seconds() { | |||
| let simulation = [ | |||
| Connect, | |||
| // | |||
| Sleep(Duration::from_millis(100)), | |||
| Sleep(Duration::MAX), | |||
There was a problem hiding this comment.
the intention is that we kill it before then
There was a problem hiding this comment.
Sorry. Color commentary.
There was a problem hiding this comment.
Missing 🤣 or something
michaelglass
approved these changes
May 30, 2023
|
Benchmarks:
Fuzz result sizes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--startup-timeout-secondsflag (andABQ_STARTUP_TIMEOUT_SECONDSenv var) to configure the maximum amount of time to wait for the native test process to startup.