Add a cucumber-js parser #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekthompson
force-pushed
the
kt/cucumber-js
branch
from
8f80955
to
edc8498
Compare
kylekthompson
commented
Apr 26, 2024
| @@ -30,7 +30,6 @@ var mutuallyExclusiveParsers []parsing.Parser = []parsing.Parser{ | |||
| new(parsing.JavaScriptMochaParser), | |||
| new(parsing.JavaScriptPlaywrightParser), | |||
| new(parsing.PythonPytestParser), | |||
| new(parsing.RubyCucumberParser), | |||
There was a problem hiding this comment.
This is not mutually exclusive. Technically a breaking change, but I no one (other than us testing the integration) has used Ruby Cucumber. Checked if this is ok w/ Tommy
The outcome is you need to specify language and framework
kylekthompson
commented
Apr 26, 2024
| } `json:"elements"` | ||
| } | ||
|
|
||
| func (p JavaScriptCucumberJSONParser) Parse(data io.Reader) (*v1.TestResults, error) { |
There was a problem hiding this comment.
This is mostly a copy of the logic in Ruby Cucumber, but a slight tweak to the before/after hook logic which ends up in Steps in the JS version instead of a separate field in the struct
tonywok
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's worth noting that technically they've deprecated their JSON format insofar as they don't intend to add new features to it.
It is however MUCH easier to parse than their JSONL messages format (which seems to intend for you to construct a graph of their objects as messages come through).
I named this parser w/ JSON in it to leave room for a future messages format parser, but this was really quick to add and unblock anyone interested in using Captain with cucumber-js
If anyone is hesitant to use the JSON formatter for this reason, it looks like they also support JUnit and the generic JUnit parser should be able to parse that