Fixes the release build #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched this off of nix, we must have misunderstood what the
-compileflag does. It builds a static binary of mage, not of your CLI.For some reason I couldn't get
mage buildto work. It was trying to execute the version of mage for the platform we were trying to build for (e.g. the windows build was trying to execute mage.exe). This should have been fixed in magefile/mage#202 but it seems like it wasn't. I decided to bypass mage altogether for the sake of expediency.Tested with this release: https://github.com/rwx-research/mint-cli/releases/tag/untagged-ce7a12e2f5930bf6d86a