Test the action #1
Conversation
|
just curious: is there an advantage of using the JS api vs a shell script? |
.github/workflows/test.yml
Outdated
| abq-token: ${{ secrets.ABQ_API_KEY }} | ||
| - run: | | ||
| echo "$PATH" | ||
| which abq |
There was a problem hiding this comment.
to ensure it's executable, what do you think about
| which abq | |
| abq --help |
Just so we can make it easier for customers to set up ABQ in their paths. I imagine later on we may want to add more functionality around here too. |
| @@ -5,7 +5,7 @@ import * as tc from '@actions/tool-cache' | |||
| function getOs() { | |||
| switch (process.platform) { | |||
| default: { | |||
| return process.arch | |||
| return process.platform | |||
There was a problem hiding this comment.
💭 should we inline this function? and/or get rid of the switch
There was a problem hiding this comment.
what binaries do we deploy to captain?
|
So for caching, GH actions exposes some nice utilities we can use, but we'll want to cache based on the canonicalized version (i.e. after "latest" is translated to a proper SEMVER) and never cache "nightly" builds. Unfortunately it's not clear to me how to parse out the canonical version from the downloaded artifact in the action right now, because actions doesnt let you stat arbitrary files/paths (makes sense). So we may need to add an API end point that just canonicalizes the version and then returns a URL to download, or something like this. What do others think? |
|
could also stash a file in the |
|
@ayazhafiz fwiw I think caching is well suited for a different PR |
|
Agreed, just something to be mindful of. |
No description provided.