-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): implement rxLet template triggers #1374
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a1be93b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
A really nice change of responsibility!!! |
BREAKING CHANGE: template-notifier does not emit suspense if the input observable has a value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not sure to fully understand what happens in the template manager, but there are tests and I can understand them so it looks fine!
I think I screwed up the build, let me fix that |
Description
Contextual Template States
implemented template triggers for rxLet directive
notable changes:
template-notifier
create-template-notifier
no longer has responsibility for the suspense template. Instead theSuspense
notification handling was improved.create-template-notifier
will now emit suspense on the following occasions:template-manager
template-manager
now takes over the responsibility of managing the suspense state, if it should be processed or not. If noSuspenseTemplate
is provided, the first suspense notification will be ignored as this would violate with rxLets lazy template nature. All consequent suspense notifications though will cause the$suspense
context variable to toggle.