Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UnhandledPromiseRejectionWarning #18

Merged

Conversation

mhjam
Copy link
Contributor

@mhjam mhjam commented Feb 20, 2020

Fixes issue #9
Fixes minor issues with tests and "prettier" script.

Copy link
Owner

@rxaviers rxaviers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your great additions. I have left a couple of comments

test/unit/index.js Outdated Show resolved Hide resolved
test/unit/index.js Outdated Show resolved Hide resolved
test/unit/index.js Outdated Show resolved Hide resolved
test/unit/index.js Outdated Show resolved Hide resolved
test/unit/index.js Outdated Show resolved Hide resolved
@mhjam mhjam requested a review from rxaviers March 13, 2020 22:22
@rxaviers
Copy link
Owner

rxaviers commented Aug 5, 2020

Sorry for the delay 🙈

@rxaviers rxaviers merged commit 1e7f18a into rxaviers:master Aug 5, 2020
@gh2k
Copy link

gh2k commented Sep 10, 2020

Any chance of a release with this fix in? I've run into the same issue.

@rxaviers
Copy link
Owner

Released 1.2.0 with the fix. Sorry for the delay, it was lost in my emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants