Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the fixed SVG diagrams into PNG and add them to the README #7

Closed
aerabi opened this issue Oct 6, 2021 · 7 comments · Fixed by #30
Closed

Convert the fixed SVG diagrams into PNG and add them to the README #7

aerabi opened this issue Oct 6, 2021 · 7 comments · Fixed by #30
Assignees
Labels
Milestone

Comments

@aerabi
Copy link
Contributor

aerabi commented Oct 6, 2021

In the context of #6, we can now convert the SVG diagrams into their PNG versions and add them into the operators' README.

@inomag
Copy link

inomag commented Oct 6, 2021

Hi @aerabi , Can I work on this issue?

@ManishS6
Copy link
Contributor

ManishS6 commented Oct 6, 2021

@aerabi As offered by you in #5 I would love to contribute to this as well.

@aerabi
Copy link
Contributor Author

aerabi commented Oct 6, 2021

Hi @aerabi , Can I work on this issue?

All the best. 🚀

@aerabi
Copy link
Contributor Author

aerabi commented Oct 6, 2021

@aerabi As offered by you in #5 I would love to contribute to this as well.

I appreciate your enthusiasm @ManishS6. Let's leave this issue to @inomag, as he volunteered first, and you can do #8 which is related to the one you fixed earlier.

@ManishS6
Copy link
Contributor

ManishS6 commented Oct 6, 2021

@aerabi As offered by you in #5 I would love to contribute to this as well.

I appreciate your enthusiasm @ManishS6. Let's leave this issue to @inomag, as he volunteered first, and you can do #8 which is related to the one you fixed earlier.

Sure, on it.

@inomag
Copy link

inomag commented Oct 6, 2021

@aerabi, I had a doubt. Do we have to add the PNG in the readme file? But, PNG is already being used in the readme.
Screenshot (219)

@aerabi
Copy link
Contributor Author

aerabi commented Oct 6, 2021

You're right, @inomag. They are already there. I thought I had removed them because they were incorrect (e.g. the diagram for flatMapLatter has flatMapFormer written on it).

Please just convert the SVGs into PNGs and then double-check the names on the diagrams in the README.

@inomag inomag removed their assignment Oct 6, 2021
@aerabi aerabi modified the milestones: v1.1.0, v1.0.0 Apr 18, 2022
@aerabi aerabi self-assigned this Apr 21, 2022
aerabi added a commit that referenced this issue Apr 21, 2022
@aerabi aerabi linked a pull request Apr 21, 2022 that will close this issue
aerabi added a commit that referenced this issue Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants