Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compile because of Use of undeclared type 'Image' #17

Closed
gorbat-o opened this issue Oct 4, 2019 · 3 comments
Closed

Do not compile because of Use of undeclared type 'Image' #17

gorbat-o opened this issue Oct 4, 2019 · 3 comments

Comments

@gorbat-o
Copy link

gorbat-o commented Oct 4, 2019

Hi,

This library does not compile since a Kingfisher update I believe.
I replaced the ImageView type with KFCrossPlatformImageView
and Image type with KFCrossPlatformImage

Will it be updated?
I can create a PR for that if needed. (I am testing right now)

@freak4pc
Copy link
Member

freak4pc commented Oct 4, 2019

Hey @gorbat-o. See this issue I opened: onevcat/Kingfisher#1303

It seems the maintainer of Kingfisher broke semantic versioning by changing symbol names without bumping a major version, thus breaking this framework. I'll try to take care of this a bit later, I just want to make sure it was only a simple rename and nothing else.

Thanks for reporting this!

@freak4pc
Copy link
Member

freak4pc commented Oct 4, 2019

He cut a new minor version, this should be fixed.

@freak4pc freak4pc closed this as completed Oct 4, 2019
@gorbat-o
Copy link
Author

gorbat-o commented Dec 6, 2019

Awesome, thank you for your quick reply!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants