feat: represent terncy scene as a homeassistant swtich #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxwen PTAL |
rxwen
reviewed
Mar 8, 2023
| @@ -367,6 +370,11 @@ async def update_or_create_entity_inner(svc, tern, model, version, available): | |||
| device = TerncyTemperatureSensor(tern, devid + DEVID_EXT_TEMP, name + "-T", model, version, features) | |||
| device.is_available = available | |||
| await add_entity_to_platform(tern, devid + DEVID_EXT_TEMP, device, attrs, PLATFORM_SENSOR) | |||
| elif model == "TERNCY-SCENE": | |||
There was a problem hiding this comment.
It's better to define a const for "TERNCY-SCENE"
| @@ -367,6 +370,11 @@ async def update_or_create_entity_inner(svc, tern, model, version, available): | |||
| device = TerncyTemperatureSensor(tern, devid + DEVID_EXT_TEMP, name + "-T", model, version, features) | |||
| device.is_available = available | |||
| await add_entity_to_platform(tern, devid + DEVID_EXT_TEMP, device, attrs, PLATFORM_SENSOR) | |||
| elif model == "TERNCY-SCENE": | |||
| device = TerncyScene(tern, devid, name, model, version, features) | |||
There was a problem hiding this comment.
We may need to forge a new devid based on the id of the returned scene, and the hub's id.
Because if user pair several different hubs, each of them may return the same scene id. If we use the scene id directly, there might be ambiguation.
For instance, devid = devid + "@" + tern.dev_id
rxwen
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terncy app is more powerful to define actions and combinations than home assistant in some use cases since the app is optimized to controlling Terncy devices. With this feature, I can create a scene to do complex actions and port it in homeassistant. I tested locally and it works smoothly.
This PR also fixes a bug introduced by 9917275:
close #24